Comments on: Refactoring / Design: Composed Method http://andypalmer.com/2008/02/refactoring-design-composed-method/ Views on software, technology, consulting and business process Sun, 31 Jan 2010 16:31:55 +0000 http://wordpress.org/?v=2.9.1 hourly 1 By: Andy http://andypalmer.com/2008/02/refactoring-design-composed-method/comment-page-1/#comment-17 Andy Tue, 12 Aug 2008 18:58:00 +0000 http://www.andypalmer.com/blog/?p=6#comment-17 That's looking good :-)<br/>The point of the post was that the first thing we should do is get to a consistent detail level.<br/>I rolled up the "how we wash our hands" into a "what are we doing?" washHands method.<br/>My feeling is that washing hands is nothing to do with the making of the base. The chef should make sure he washes his hands before he starts making the base, but we'll get there eventually :-) That’s looking good :-)
The point of the post was that the first thing we should do is get to a consistent detail level.
I rolled up the “how we wash our hands” into a “what are we doing?” washHands method.
My feeling is that washing hands is nothing to do with the making of the base. The chef should make sure he washes his hands before he starts making the base, but we’ll get there eventually :-)

]]> By: Kris http://andypalmer.com/2008/02/refactoring-design-composed-method/comment-page-1/#comment-7 Kris Sun, 10 Aug 2008 23:10:00 +0000 http://www.andypalmer.com/blog/?p=6#comment-7 I'm not a fan of a CheeseCake taking in a chef and a sink and instructing the chef to wash his hands, but perhaps I'm jumping ahead in your story. Anyway, I think I would rather see an initial refactoring look more like this:<br/><br/>public makeBase(Ingredients... ingredients) {<br/>    chef.washHandsIn(sink);<br/>    bowl.add(ingredients);<br/>    chef.mixIngredientsOf(bowl); <br/>    cake.addContents(bowl);<br/>}<br/><br/>I'm not claiming this is perfect, but would be more in-line with a first phase refactoring:<br/><br/>1. Washing hands is a behaviour between the chef and sink. The details of which should not be exposed to the cheesecake.<br/><br/>2. The ingredients getting added to a bowl pushes the loop as a single operation into a single method.<br/><br/>3. Might as well move the construction of all the objects but allow them to be injected. I'm not a fan of a CheeseCake taking in a chef and a sink and instructing the chef to wash his hands, but perhaps I'm jumping ahead in your story. Anyway, I think I would rather see an initial refactoring look more like this:

public makeBase(Ingredients… ingredients) {
    chef.washHandsIn(sink);
    bowl.add(ingredients);
    chef.mixIngredientsOf(bowl);
    cake.addContents(bowl);
}

I'm not claiming this is perfect, but would be more in-line with a first phase refactoring:

1. Washing hands is a behaviour between the chef and sink. The details of which should not be exposed to the cheesecake.

2. The ingredients getting added to a bowl pushes the loop as a single operation into a single method.

3. Might as well move the construction of all the objects but allow them to be injected.

]]>